Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mention component interrupt IME #3595

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

WindRunnerMax
Copy link
Contributor

I'm currently researching plate.js for its editor capabilities, and I came across an issue with the mention component similar to the one in ianstormtaylor/slate#5685.

So I decided to fix this issue. On MacOS browsers, typing in nodes after the spacer tag interrupts the IME. Additionally, pressing the delete key at this point also causes some issues with the selection position.

Moving the spacer node forward can fix this issue. However, on Android devices, it still needs to stay in its original position.

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

Copy link

codesandbox bot commented Sep 30, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: 2fbc926

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 11:44pm

@WindRunnerMax WindRunnerMax changed the title fix: mention interrupt ime fix: mention component interrupt IME Sep 30, 2024
@zbeyens zbeyens requested a review from 12joan September 30, 2024 16:23
@zbeyens zbeyens merged commit 8070409 into udecode:main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants