Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve line breaks during markdown deserialization #3679

Merged
merged 13 commits into from
Nov 18, 2024
Merged

Conversation

natamox
Copy link
Collaborator

@natamox natamox commented Oct 28, 2024

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

Copy link

codesandbox bot commented Oct 28, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 564769a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@udecode/plate-markdown Patch
@udecode/plate-ai Patch
@udecode/plate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 4:42pm

@natamox natamox requested a review from 12joan October 28, 2024 06:12
@natamox natamox changed the title Feat/deserialize md preserve line breaks during markdown deserialization Oct 28, 2024
packages/markdown/src/lib/MarkdownPlugin.ts Outdated Show resolved Hide resolved
packages/markdown/src/lib/remark-slate/remarkPlugin.ts Outdated Show resolved Hide resolved
chenxiaofei added 2 commits November 18, 2024 17:34
12joan
12joan previously approved these changes Nov 18, 2024
@zbeyens
Copy link
Member

zbeyens commented Nov 18, 2024

@natamox Looks great! Could you just add a changeset for the release?

@zbeyens zbeyens merged commit aa93637 into main Nov 18, 2024
5 of 6 checks passed
@zbeyens zbeyens deleted the feat/deserialize-md branch November 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants