Media #3708
Merged
Media #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 702ad16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zbeyens
reviewed
Nov 4, 2024
Co-authored-by: Ziad Beyens <[email protected]>
zbeyens
requested changes
Nov 4, 2024
| data: { invalidateFiles: File[] }; | ||
| }; | ||
|
|
||
| export type uploadConfig = Partial<Record<AllowedFileType, MediaItemConfig>>; |
There was a problem hiding this comment.
Suggested change
| export type uploadConfig = Partial<Record<AllowedFileType, MediaItemConfig>>; | |
| export type UploadConfig = Partial<Record<AllowedFileType, MediaItemConfig>>; |
|
|
||
| export type UploadError = { | ||
| code: UploadErrorCode; | ||
| data: { invalidateFiles: File[] }; |
There was a problem hiding this comment.
Suggested change
| data: { invalidateFiles: File[] }; | |
| data: { files: File[] }; |
| uploadingFiles: Record<string, File>; | ||
| // Whether multiple files of the same type can be uploaded. | ||
| multiple?: boolean; | ||
| uploadError?: UploadError | null; |
There was a problem hiding this comment.
Suggested change
| uploadError?: UploadError | null; | |
| error?: UploadError | null; |
| // Whether multiple files of the same type can be uploaded. | ||
| multiple?: boolean; | ||
| uploadError?: UploadError | null; | ||
| uploadMaxFileCount?: number; |
There was a problem hiding this comment.
Suggested change
| uploadMaxFileCount?: number; | |
| maxFileCount?: number; |
| }, | ||
| })) | ||
| .extendApi(({ getOption, setOption }) => ({ | ||
| addUploadingFile: (id: string, file: File) => { |
There was a problem hiding this comment.
Suggested change
| addUploadingFile: (id: string, file: File) => { | |
| addFile: (id: string, file: File) => { |
same for others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn typecheckyarn lint:fixyarn testyarn brlyarn changeset