Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export #3807

Merged
merged 8 commits into from
Nov 26, 2024
Merged

export #3807

merged 8 commits into from
Nov 26, 2024

Conversation

felixfeng33
Copy link
Collaborator

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Nov 26, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c94b28c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 11:50am

zbeyens
zbeyens reviewed Nov 26, 2024
View reviewed changes
apps/www/src/registry/default/plate-ui/pdf-toolbar-button.tsx Outdated Show resolved Hide resolved
apps/www/src/registry/default/plate-ui/pdf-toolbar-button.tsx Outdated Show resolved Hide resolved
apps/www/content/docs/examples/export.mdx Show resolved Hide resolved
apps/www/src/registry/default/plate-ui/editor.tsx Outdated
Comment on lines 49 to 50
// Adding this role attribute could cause the content captured by html2canvas to be incorrectly centered.
// role="button"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed

apps/www/src/styles/globals.css Outdated Show resolved Hide resolved
zbeyens
zbeyens previously approved these changes Nov 26, 2024
View reviewed changes
@felixfeng33 felixfeng33 merged commit a1193d9 into main Nov 26, 2024
8 checks passed
@felixfeng33 felixfeng33 deleted the html2canvas branch November 26, 2024 11:58
@zbeyens zbeyens added the ui label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbeyens zbeyens zbeyens left review comments

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfeng33 @zbeyens