Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with -notation-overridden compile option #231

Merged
merged 13 commits into from
Jan 24, 2025

Conversation

DmxLarchey
Copy link
Collaborator

@DmxLarchey DmxLarchey commented Jan 23, 2025

So far:

  • the ILL/* sub-folders cleaned up by introducing Modules for notations;

Currently remaining, exhaustive list:

  • FOL/FOL.v;
  • FOL/binFST_undec.v;
  • FOL/Semantics/FiniteTarski/DoubleNegation.v;
  • FOL/Utils/FriedmanTranslation.v;
  • FOL/Utils/FriedmanTranslationFragment.v;
  • FOL/Reductions/H10UPC_to_FOL_friedman.v;
  • FOL/Reductions/H10p_to_FA.v;
  • FOL/Reductions/binZF_to_binFST.v;
  • FOL/Reductions/ZF_to_FST.v;
  • SOL/Util/PA2_facts.v;
  • TM/Reductions/SBTM_HALT_to_HaltTM_1.v;
  • TM/Reductions/HaltTM_1_to_SBTM_HALT.v.

@DmxLarchey DmxLarchey marked this pull request as draft January 23, 2025 15:37
@DmxLarchey DmxLarchey requested a review from mrhaandi January 23, 2025 15:40
@DmxLarchey
Copy link
Collaborator Author

@mrhaandi considering that I did not contribute to the remaining files, I am going to push the PR in this state, letting the -notation-overridden option active in _CoqProject.

Then, I will file a new PR and associate @dominik-kirst to that so he can check that I am not proposing unwanted changes in that code, or possibly contribute updates himself.

@DmxLarchey DmxLarchey marked this pull request as ready for review January 24, 2025 09:37
@mrhaandi
Copy link
Collaborator

Shortly, I'll have a change to your PR which will address TM and SOL.

@mrhaandi
Copy link
Collaborator

See DmxLarchey#15 for TM and SOL.

@DmxLarchey
Copy link
Collaborator Author

See DmxLarchey#15 for TM and SOL.

For the record, I tried to inspect your PR but it fails and I do not understand why. It does not seem permission related.

larcheypc theories % gh pr checkout mrhaandi:notation-overridden
Depuis github.com:DmxLarchey/coq-library-undecidability
 * branch              refs/pull/15/head -> FETCH_HEAD
fatal: Pas possible d'avancer rapidement, abandon.
failed to run git: exit status 128

@mrhaandi
Copy link
Collaborator

For the record, I tried to inspect your PR but it fails and I do not understand why. It does not seem permission related.

Possibly because your PR is further in the history and one needs to rebase or merge my PR to avoid conflicts.

@DmxLarchey
Copy link
Collaborator Author

Well the issue was not (commit) history related. I have not found out the explanation.

@DmxLarchey DmxLarchey merged commit 939e11d into uds-psl:master Jan 24, 2025
1 check passed
@DmxLarchey DmxLarchey deleted the notation-overridden branch January 24, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants