Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinning python libraries version #193

Merged
merged 2 commits into from
Nov 7, 2022
Merged

pinning python libraries version #193

merged 2 commits into from
Nov 7, 2022

Conversation

Azuki-bar
Copy link
Member

再現性のあるコンテナイメージを作るためにライブラリのバージョンを固定

#192

@Azuki-bar Azuki-bar requested a review from n4o847 November 7, 2022 13:09
Copy link
Collaborator

@n4o847 n4o847 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です

@n4o847
Copy link
Collaborator

n4o847 commented Nov 7, 2022

本当は poetry とか pipfile とか使うほうがモダンなんだろうなぁと思いつつ、requirements.txt ですみません

@Azuki-bar
Copy link
Member Author

レビューありがとうございます。 #196 とマージしそうなので #196 がmainに取り込まれるのを待ちます

@Azuki-bar Azuki-bar merged commit 3e2becd into main Nov 7, 2022
@Azuki-bar Azuki-bar deleted the pin-python-version branch November 7, 2022 14:13
@github-actions github-actions bot mentioned this pull request Nov 7, 2022
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants