Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Update weather model hash to 0682f90 (January 28) and add smoke/dust WE2E test to testing suites #1195

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

MichaelLueken
Copy link
Collaborator

DESCRIPTION OF CHANGES:

  • Update weather model hash to 0682f90 from January 28, 2025
  • Add smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf WE2E test to coverage.gaea-c6, comprehensive and comprehensive.orion (sym linked to comprehensive.gaea-c6 and comprehensive.hercules)
  • Add:
load(pathJoin("nco", os.getenv("nco_ver") or "5.0.6"))
load(pathJoin("prod_util", os.getenv("prod_util_ver") or "2.1.1"))

to modulefiles/build_hera_gnu.lua.

  • Address documentation failures now that https://www.fvcom.org site's security certificate has been renewed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

TESTS CONDUCTED:

  • derecho.intel - Comprehensive, Fire, and AQM WE2E tests
  • gaea.intel - Comprehensive and Fire WE2E tests
  • gaea-c6.intel - Comprehensive and Fire WE2E tests
  • hera.gnu - Comprehensive and Fire WE2E tests
  • hera.intel - Comprehensive, Fire, and AQM WE2E tests
  • hercules.intel - Comprehensive, Fire, and AQM WE2E tests
  • orion.intel - Comprehensive, Fire, and AQM WE2E tests
  • Jenkins - Fire and AQM WE2E tests were run using the new srw-fire-aqm Jenkins pipeline
  • comprehensive tests - All comprehensive tests were run and the new smoke/dust WE2E was added on machines that support the capability

DOCUMENTATION:

Updated documentation to address failures in the Doc Tests following the renewal of the https://www.fvcom.org security certificate

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes

MichaelLueken and others added 10 commits January 31, 2025 18:20
…0 (January 28, 2025) and add smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf to tests/WE2E/machine_suites/comprehensive
…e_HRRR_gf to tests/WE2E/machine_suites/comprehensive.orion and replace sym link for tests/WE2E/machine_suites/comprehensive.gaea (can't run smoke_dust_grid_RRFS_CONUS_3km_suite_HRRR_gf on Gaea-C5)
…o allow the smoke_dust WE2E test to run on Hera using GNU-built executables
…e_HRRR_gf WE2E test to coverage.gaea-c6 test suite
…ion now that the security certificate for https://www.fvcom.org has been renewed
…o the list of mocked modules for building documentation
@MichaelLueken MichaelLueken requested a review from WeirAE as a code owner February 7, 2025 16:17
@MichaelLueken
Copy link
Collaborator Author

Will change PR to draft until PR #2601 in the weather model has been merged, then I will update the hash, so that we don't need multiple PRs.

@MichaelLueken MichaelLueken marked this pull request as draft February 13, 2025 18:36
@MichaelLueken
Copy link
Collaborator Author

It sounds like PR #2597 will be merged early next week. I will keep this PR in draft until that is added, since it will be required for the RRFS_sas physics suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant