Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop:] Add the RRFS_SaS physics suite to SRW options #1201

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

natalie-perlin
Copy link
Collaborator

DESCRIPTION OF CHANGES:

RRFS_sas suite is added to the SRW physics suite options.
This scheme was used in RRFSv1 production runs between ~August to December 2024.

This code still uses sfc_data.nc older (v1) format.

Files modified or added (*):

  • parm/FV3.input.yml (*)
  • parm/diag_table.RRFS_sas (*)
  • parm/field_table.RRFS_sas (*)
  • scripts/exregional_make_orog.sh
  • scripts/exregional_make_ics.sh
  • scripts/exregional_make_lbcs.sh
  • ush/link_fix.py
  • ush/setup.py
  • ush/valid_param_vals.yaml

NB: With the currently used hashes of ufs-srweather-app and FV3atm in this draft PR, an additional namelist file suite_RRFS_sas.xml is to be placed under ./sorc/ufs-weather-model/FV3/./ccpp/suites/suite_RRFS_sas.xml

@MichaelLueken brought changes to the UFS_UTILS branch in NOAA-EPIC repository that allowed preparing input data correctly for the FV3atm model.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

Testing on Hera and Orion at the moment.

  • derecho.intel
  • gaea.intel
  • gaea-c6.intel
  • hera.gnu
  • hera.intel
  • hercules.intel
  • jet.intel
  • orion.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

This closes an issue #1192

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

@MichaelLueken

@natalie-perlin natalie-perlin marked this pull request as draft February 14, 2025 14:48
@MichaelLueken MichaelLueken added Work in Progress release This PR/issue is related to a release branch Priority: HIGH labels Feb 14, 2025
@MichaelLueken MichaelLueken linked an issue Feb 14, 2025 that may be closed by this pull request
@natalie-perlin natalie-perlin changed the title Add the RRFS_SaS physics suite to SRW options [develop:] Add the RRFS_SaS physics suite to SRW options Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: HIGH release This PR/issue is related to a release branch Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new physics suite RRFS_sas to SRW options
2 participants