fix: handle fps being None

[bdraco]

see home-assistant/core#137283

Summary by CodeRabbit

• Bug Fixes
  • Improved the handling of missing or undefined frame rate information in camera channels, ensuring smoother operation and reducing potential errors during usage.

[coderabbitai]

Walkthrough

The pull request modifies the CameraChannel class in src/uiprotect/data/devices.py. The changes update the fps attribute’s type from int to int | None with a default of None. Additionally, the is_package property is updated to verify that fps is not None before performing a comparison with 2, enhancing type safety and preventing potential runtime errors.

Changes

File	Change Summary
src/uiprotect/.../devices.py	Updated CameraChannel: Changed fps type to `int

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Caller
    participant CC as CameraChannel

    Caller->>CC: Access is_package property
    alt fps is None
        CC-->>Caller: Return False
    else fps is set
        CC-->>Caller: Compare fps with 2, return result
    end

Loading

Poem

Oh, I’m the rabbit with code so fine,
Jumping through changes in record time.
The fps can now be none or real,
Preventing errors with a clever seal!
With each hop, my code sings a tune,
Dancing with bytes beneath the moon.
Happy coding from the burrow of CodeRabbit!

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba2f8fd and 39a6a47.

📒 Files selected for processing (1)

• src/uiprotect/data/devices.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: test (3.13, ubuntu-latest, 2)
• GitHub Check: test (3.12, ubuntu-latest, 2)
• GitHub Check: test (3.11, ubuntu-latest, 2)
• GitHub Check: test (3.10, ubuntu-latest, 2)

🔇 Additional comments (2)

src/uiprotect/data/devices.py (2)

251-251: LGTM! The fps attribute type change looks good.

The change to make fps nullable with a default value of None improves type safety and better handles cases where fps information is not available.

---

299-299: LGTM! The is_package property now safely handles None fps values.

The added None check prevents potential runtime errors and properly handles cases where fps information is not available.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/uiprotect/data/devices.py	50.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/uiprotect/data/devices.py	86.39% <50.00%> (ø)

[bdraco]

Would be great if we had a dump so we could get coverage for this, but since 2025.2 is tomorrow, I'm going to merge it anyways