Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop/print config type #11

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

victorywys
Copy link
Contributor

In order to reconstruct an instance solely from logs, one need to know the type of a config class besides its parameters. In this commit, a config_type.json will be generated containing such information.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c7bf170) 67.56% compared to head (78888a5) 72.42%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   67.56%   72.42%   +4.85%     
==========================================
  Files          33       33              
  Lines        1927     1962      +35     
==========================================
+ Hits         1302     1421     +119     
+ Misses        625      541      -84     
Files Coverage Δ
utilsd/fileio/config.py 89.55% <100.00%> (ø)
utilsd/experiment.py 73.33% <82.05%> (+49.85%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victorywys victorywys marked this pull request as ready for review November 1, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants