-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose service IP and port as variables in service providers #1498
base: develop
Are you sure you want to change the base?
Conversation
I've tested this with the localhost server and a server on a NUC on the same network (in-Editor and as a built app). It worked successfully. |
I think it would be valuable to be able to programmatically set the IP and Port a LeapServiceProvider connects to. Only being able to set this at development time means a developer is always necessary to make that change. If it was doable programmatically, it can be changed in-app or via config with limited technical resources. |
I strongly hope this fix will be merged. |
Summary
This replaces the
_serverNameSpace
with_serverIP
and_serverPort
._serverNameSpace
was used back in Orion when it was using named pipes. It is now using TCP and although LeapC still uses a variable calledserver_namespace
, it can be used to connect to a service listening on a different IP/port by passing a JSON payload containingtracking_server_ip
andtracking_server_port
:Contributor Tasks
breaking
to this MR.Reviewer Tasks
Add any instructions or tasks for the reviewer such as specific test considerations before this can be merged.
Use emojis in review threads to communicate intent and help contributors.
Closes JIRA Issue
Closes UNITY-1217