Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose service IP and port as variables in service providers #1498

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

RodolpheHoudas-UL
Copy link
Contributor

@RodolpheHoudas-UL RodolpheHoudas-UL commented Aug 31, 2023

Summary

This replaces the _serverNameSpace with _serverIP and _serverPort. _serverNameSpace was used back in Orion when it was using named pipes. It is now using TCP and although LeapC still uses a variable called server_namespace, it can be used to connect to a service listening on a different IP/port by passing a JSON payload containing tracking_server_ip and tracking_server_port:

Contributor Tasks

  • Create or edit test cases here
  • Add a CHANGELOG entry for this change.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.
  • Add any relevant labels such as breaking to this MR.

Reviewer Tasks

Add any instructions or tasks for the reviewer such as specific test considerations before this can be merged.

Use emojis in review threads to communicate intent and help contributors.

  • Run all tests associated with the ticket.
  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • Documentation has been reviewed.
  • Approve with a comment of any additional tests run or any observations.

Closes JIRA Issue

Closes UNITY-1217

@robinhawkins-UH
Copy link

I've tested this with the localhost server and a server on a NUC on the same network (in-Editor and as a built app). It worked successfully.

@robinhawkins-UH
Copy link

robinhawkins-UH commented Oct 30, 2023

I think it would be valuable to be able to programmatically set the IP and Port a LeapServiceProvider connects to. Only being able to set this at development time means a developer is always necessary to make that change. If it was doable programmatically, it can be changed in-app or via config with limited technical resources.

@tichise
Copy link

tichise commented Sep 29, 2024

I strongly hope this fix will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants