Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/unity 1463 fix device id on frame #1562

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

MaxPalmer-UH
Copy link
Contributor

Summary

Device IDs are not set correctly on Frame objects, particularly when handling playback of data via LeapCtrl, which will create new devices per playback.

Contributor Tasks

  • Create or edit test cases here
  • Add a CHANGELOG entry for this change.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.

Test Cycle

Link to the test cycle here.

Reviewer Tasks

  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • All tests must be ran and cover all scenarios (If not, add new tests to the cycle and run them).
  • Documentation has been reviewed.
  • Approve with a comment of any additional tests run or any observations.

Related JIRA Issues

If this MR closes any JIRA issues list them below in the form Closes PROJECT-#

Pull Request Templates

Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.

You are currently using: default.md

Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with &template=name.md instead of using the link. See query parameter docs for more information.

@MaxPalmer-UH
Copy link
Contributor Author

Sorry, accidentally branched off the raw frame ready branch.

Comment on lines +651 to +654
if (_currentDevice != null)
{
_untransformedFixedFrame.DeviceID = _currentDevice.DeviceID;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might actually draw attention to a larger issue

Conection.Frames has no idea about devices, and so is a stack of all frames, regardless of device. We then populate it with whichever frame is available

This means when interpolation is not enabled, the provided data can be from any active device, regardless of the device that should be used for the specific LeapServiceProvider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants