Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the target colour palette values for joint confidence targets … #1564

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

MaxPalmer-UH
Copy link
Contributor

…in the render texture as they appear altered from the expected values

Summary

When investigating the Lumi work, it appeared that the joint values calculated in the render texture, which are used as the target pixel colours for counting / calculating joint visibility do not match the source values used to render the capsule hands. This is unexpected but several days of looking for potential causes failed to determine the issue. This code contains new target values, based on the pixel colours in the rendertexture and also some code that can be used to log out the colours, which is useful in checking if this is an issue that occurs across multiple systems/versions/platforms.

Contributor Tasks

  • Create or edit test cases here
  • Add a CHANGELOG entry for this change.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.

Test Cycle

Link to the test cycle here.

Reviewer Tasks

  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • All tests must be ran and cover all scenarios (If not, add new tests to the cycle and run them).
  • Documentation has been reviewed.
  • Approve with a comment of any additional tests run or any observations.

Related JIRA Issues

If this MR closes any JIRA issues list them below in the form Closes PROJECT-#

Pull Request Templates

Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.

You are currently using: default.md

Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with &template=name.md instead of using the link. See query parameter docs for more information.

Max Palme and others added 4 commits March 5, 2024 17:14
…in the render texture as they appear altered from the expected values
Restored omitted comments
…values_not_calculated_as_expected_due_to_colour_shift
@@ -1,3 +1,7 @@

// Tue this to log out the render colours seen by the camera in the render texture
#define LOGGING_RENDER_COLOURS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be disabled by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants