Take extra program search paths into account when searching for VCS programs #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation for this change comes from the desire to have --extra-prog-path available when searching for VCS programs (at that point, it turns, we only have a handle on a shared project config), but it makes sense in general too. Technically, the legacy flag configProgramPathExtra, which holds the value of --extra-prog-path, did not propagate to shared project config before, although the latter has a field for that sort of thing (projectConfigProgPathExtra). So, we fix it. A little awkward is that another legacy flag, globalProgPathExtra, also holds the same kind of information, so, when turning legacy flags into a shared project config we merge the two legacy flags and assign the result to projectConfigProgPathExtra.
ulysses4ever
force-pushed
the
master
branch
8 times, most recently
from
c11a015
to
7402038
Compare
ulysses4ever
force-pushed
the
master
branch
7 times, most recently
from
b187832
to
8e31729
Compare
ulysses4ever
force-pushed
the
master
branch
5 times, most recently
from
ca9325f
to
50bbf61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!