Skip to content

Commit

Permalink
Merge pull request #2185 from umbraco/v14.2/hotfix/temp-location-for-…
Browse files Browse the repository at this point in the history
…manifest-viewer

Chore: temp solution: move manifest viewer files to the blocks package
  • Loading branch information
leekelleher authored Aug 7, 2024
2 parents 13d7c4e + a69fd2e commit 2d6e4a5
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import { UMB_MANIFEST_VIEWER_MODAL } from '../../../modals/manifest-viewer/index.js';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import { html, customElement, state, property, css } from '@umbraco-cms/backoffice/external/lit';
import { UMB_PROPERTY_DATASET_CONTEXT } from '@umbraco-cms/backoffice/property';
import {
UMB_MANIFEST_VIEWER_MODAL,
umbExtensionsRegistry,
type ManifestBlockEditorCustomView,
} from '@umbraco-cms/backoffice/extension-registry';
import { umbExtensionsRegistry, type ManifestBlockEditorCustomView } from '@umbraco-cms/backoffice/extension-registry';
import { stringOrStringArrayContains } from '@umbraco-cms/backoffice/utils';
import { UmbExtensionsManifestInitializer } from '@umbraco-cms/backoffice/extension-api';
import { UmbDocumentTypeDetailRepository } from '@umbraco-cms/backoffice/document-type';
Expand Down
2 changes: 2 additions & 0 deletions src/packages/block/manifests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { manifests as blockGridManifests } from './block-grid/manifests.js';
import { manifests as blockListManifests } from './block-list/manifests.js';
import { manifests as blockRteManifests } from './block-rte/manifests.js';
import { manifests as blockTypeManifests } from './block-type/manifests.js';
import { manifest as modalManifest } from './modals/manifest-viewer/manifest.js';
import type { ManifestTypes } from '@umbraco-cms/backoffice/extension-registry';
// TODO: Remove test custom view, or transfer to test or similar?
//import { manifest } from './custom-view/manifest.js';
Expand All @@ -14,4 +15,5 @@ export const manifests: Array<ManifestTypes> = [
...blockListManifests,
...blockGridManifests,
...blockRteManifests,
modalManifest,
];
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ export interface UmbManifestViewerModalData extends ManifestBase {}

export type UmbManifestViewerModalValue = undefined;

/* TODO: This is a temporary location for the manifest viewer files.They are located here because of build issues.
Please don't export this token from the block package. [MR] */
export const UMB_MANIFEST_VIEWER_MODAL = new UmbModalToken<UmbManifestViewerModalData, UmbManifestViewerModalValue>(
'Umb.Modal.ManifestViewer',
{
Expand Down
1 change: 0 additions & 1 deletion src/packages/core/extension-registry/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
export * from './conditions/index.js';
export * from './initializers/index.js';
export * from './modals/manifest-viewer/index.js';
export * from './registry.js';
export * from './utils/index.js';
export type * from './interfaces/index.js';
Expand Down
2 changes: 0 additions & 2 deletions src/packages/core/extension-registry/manifests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { manifests as menuItemManifests } from './menu-item/manifests.js';
import { manifests as workspaceManifests } from './workspace/manifests.js';
import { manifests as collectionManifests } from './collection/manifests.js';
import { manifests as entityActionManifests } from './entity-actions/manifests.js';
import { manifest as modalManifest } from './modals/manifest-viewer/manifest.js';
import type { ManifestTypes } from './models/index.js';

export const manifests: Array<ManifestTypes> = [
Expand All @@ -12,5 +11,4 @@ export const manifests: Array<ManifestTypes> = [
...workspaceManifests,
...collectionManifests,
...entityActionManifests,
modalManifest,
];

0 comments on commit 2d6e4a5

Please sign in to comment.