Skip to content

Commit

Permalink
update support to nodejs 20
Browse files Browse the repository at this point in the history
  • Loading branch information
iOvergaard committed Nov 3, 2023
1 parent e53179d commit 6de3ce2
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 78 deletions.
49 changes: 0 additions & 49 deletions .github/workflows/azure-static-web-apps-ashy-bay-09f36a803.yml

This file was deleted.

45 changes: 22 additions & 23 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ name: Build and test

on:
push:
branches: [ main ]
branches: [main]
pull_request:
branches: [ main ]
branches: [main]

# Allows GitHub to use this workflow to validate the merge queue
merge_group:
Expand All @@ -20,33 +20,32 @@ env:

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [18.x]
node-version: [20]

steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: npm ci --no-audit --no-fund --prefer-offline
- run: npm run lint
- run: npm run build
- run: npm run generate:jsonschema:dist
- run: sudo npx playwright install-deps
- run: npm test
- name: Upload Code Coverage reports
uses: actions/upload-artifact@v3
if: always()
with:
name: code-coverage
path: coverage/
retention-days: 30
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: npm ci --no-audit --no-fund --prefer-offline
- run: npm run lint
- run: npm run build
- run: npm run generate:jsonschema:dist
- run: sudo npx playwright install-deps
- run: npm test
- name: Upload Code Coverage reports
uses: actions/upload-artifact@v3
if: always()
with:
name: code-coverage
path: coverage/
retention-days: 30
# Commented out since it is outdated and is quite spammy
# - name: Report code coverage
# uses: zgosalvez/github-actions-report-lcov@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-publish-github-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
ref: ${{ inputs.ref }}
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20
cache: 'npm'
registry-url: https://registry.npmjs.org/
scope: '@umbraco-cms'
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.16
20.9
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@
"prepublishOnly": "node ./devops/publish/cleanse-pkg.js"
},
"engines": {
"node": ">=18.14 <19",
"npm": ">=9.5 < 10"
"node": ">=20.9 <21",
"npm": ">=10.1 < 11"
},
"dependencies": {
"@openid/appauth": "^1.3.1",
Expand Down

0 comments on commit 6de3ce2

Please sign in to comment.