Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize TypeScript Support for CSS Modules #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fa3eng
Copy link

@fa3eng fa3eng commented Nov 16, 2024

优化 CSS Modules 的 TypeScript 类型支持

解决方案

  1. 在 write_types 执行阶段安装 typescript-plugin-css-modules 依赖
  2. 优化 PackageManager,新增方法支持安装指定依赖,避免循环调用问题
  • 之前的 install 方法会触发 postinstall -> sync -> install 的循环
  • 新增专门的方法用于安装单个依赖包
  1. 在 tsconfig.json 中添加插件配置

Optimize TypeScript Support for CSS Modules

Solution

  1. Install typescript-plugin-css-modules dependency during write_types execution
  2. Optimize PackageManager by adding method to install specific dependencies, avoiding circular calls:
  • Previous install method triggered postinstall -> sync -> install loop
  • Add dedicated method for single package installation
  1. Add plugin configuration in tsconfig.json

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests and other checks with pnpm ci

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features and fix bugs should all be patch before we release 0.1.0. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Nov 16, 2024

⚠️ No Changeset found

Latest commit: 370eb05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fa3eng
Copy link
Author

fa3eng commented Nov 16, 2024

#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant