Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #11514 #11526

Closed
wants to merge 2 commits into from
Closed

fix: #11514 #11526

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e739a2e
fix: #11514
fengsx Aug 17, 2023
d5a4c6e
Merge branch 'umijs:master' into master
fengsx Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/plugins/libs/qiankun/slave/slaveRuntimePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ export function modifyClientRenderOpts(memo: any) {
const clientRenderOpts = contextOptsStack.shift();
const { basename, historyType } = memo;

// use ?? instead of ||, incase clientRenderOpts.basename is ''
// only break when microApp has a config.base and mount path is /*
const newBasename = clientRenderOpts?.basename ?? basename;
const newBasename = clientRenderOpts?.basename || basename;
const newHistoryType = clientRenderOpts?.historyType || historyType;

if (newHistoryType !== historyType || newBasename !== basename) {
Expand Down
Loading