(Feature) SeekBar Highlighting: Highlight section of seekbar where subtitles have been generated #97
Conversation
KRSHH
commented
Apr 27, 2025
KRSHH
commented
There was a problem hiding this comment.
Hi @KRSHH, Thanks for the PR!
I've made some comments, it would be appreciated if you could fix it.
When ASR is started in the middle, the first half of the seek bar seems to be highlighted as well.
So the starting point may also need to be managed. Is this difficult to solve?
(You have to move the seek bar to the left most to see it.)
I want to add the ability to wrap ASR in the future, so it may be possible to fix it at that time.
LLPlayer/Resources/Slider.xaml
Outdated
| VerticalAlignment="Center" | ||
| Visibility="Collapsed" | ||
| Margin="0,0,0,0" | ||
| Panel.ZIndex="2" /> |
There was a problem hiding this comment.
In the case of the same Row and Column, the one written on the bottom has priority and is displayed on the top.
Therefore, if you want to place this Border at the bottom, it is better to define it at the top.
Please control zindex in the order you define.
| // Update the latest subtitle time if this one is later | ||
| if (data.EndTime.Ticks > _latestSubtitleTime) | ||
| { | ||
| LatestSubtitleTime = data.EndTime.Ticks; |
There was a problem hiding this comment.
It may be better to add a timer and update when X seconds have elapsed.
Frequent UI updates using dispatcher should be avoided for performance reasons.
|
|
||
| // When ASR completes successfully, set the latest subtitle time to the full duration | ||
| // This will fill the entire seekbar with the yellow highlight | ||
| if (_config?.Subtitles?.player?.Duration > 0) |
| if (_latestSubtitleTime != value) | ||
| { | ||
| _latestSubtitleTime = value; | ||
| Utils.UI(() => Raise(nameof(LatestSubtitleTime))); |
There was a problem hiding this comment.
SetUI(ref _latestSubtitleTime, value);
LLPlayer/Resources/Slider.xaml
Outdated
| <Border | ||
| x:Name="subtitleProcessingTrack" | ||
| Grid.Row="1" | ||
| Background="#FFEE22" |
There was a problem hiding this comment.
It would be better to avoid hard-corded colors for custom theme.
The following colors may be a good choice
// white color
Background="{DynamicResource MaterialDesignBody}"
// lighter primary color
Background="{DynamicResource MaterialDesign.Brush.Primary.Light}"
| @@ -210,6 +236,12 @@ public bool Execute(int subIndex, string url, int streamIndex, MediaType type, T | |||
|
|
|||
| lock (_lockerSubs) | |||
| { | |||
| // Update the latest subtitle time if this one is later | |||
| if (data.EndTime.Ticks > _latestSubtitleTime) | |||
There was a problem hiding this comment.
This if statement may not be necessary since currently it removes everything after the added subtitle.
…ering, removed hardcoding in color of highlight, removed redundant statements
|
Hi @umlx5h I have made few changes in my previous commit |
