fix-rename-shortCode-shortcode #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @McPizza0 and the rest of your teammates on |
…n/inbox into fix-rename-shortCode-shortcode
BlankParticle
approved these changes
Jul 18, 2024
Merge activity
|
OmarMcAdam
added a commit
that referenced
this pull request
Jul 22, 2024
Co-authored-by: Yash Khatri <[email protected]> Co-authored-by: BlankParticle <[email protected]> Co-authored-by: McPizza <[email protected]> Co-authored-by: Chris <[email protected]> Co-authored-by: Yash Khatri <[email protected]> Co-authored-by: Rohit Kumar Saini <[email protected]> Co-authored-by: Esther Lizardo <[email protected]> Co-authored-by: ben <[email protected]> fix: file name generation for missing filenames for attachments (#533) fix: replace convo list with Virtuoso component to fix bugs (#536) fix: new email based participants are correctly added now (#538) Fixes #215 fix: check org shortCode availability before creating org (#544) fix: password auto complete suggestion fix (#546) fixed (#558) fix(signup): save profile without avatar (#561) Fixes #549 fix: make trpc redirects work in web (#555) fix (#565) Fixes #564 fix: rename the postal local mode env variable to be proper one (#573) fix (#576) fix and input box default length fix (#570) fix-redirect-when-already-in-org (#578) fix-rename-shortCode-shortcode (#580) fixes #507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactor codebase to standardize the naming of
orgShortCodetoorgShortcodefor consistency.What changed?
Renamed all instances of
orgShortCodetoorgShortcodeacross multiple files in the project, including both variable names and function names. This refactor touches files in various directories, including but not limited to:apps/mail-bridge/queue/mail-processor/worker.tsapps/platform/routes/auth.tsapps/platform/routes/realtime.tsapps/platform/trpc/routers/authRouter/passwordRouter.tsapps/web/src/app/(login)/login/page.tsxHow to test?
orgShortCodeis involved to confirm that everything works as expected.Why make this change?
To maintain consistency across the codebase and prevent any confusion related to the naming of the organization short code variable.
What does this PR do?
Fixes # (issue)
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists
Type of change
Checklist
Required
console.logsgit pull origin mainAppreciated