Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(new-convo): empty email identity handled #711

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

SySagar
Copy link
Contributor

@SySagar SySagar commented Aug 19, 2024

What does this PR do?

Fixes #709

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Additional note:

So if you disable the add participant then the email identity drop box hides itself. Howsoever I have still handled it. Also I wanna ask if there exist no email identity then should be disable the entire form rather than just the participant.

Copy link
Member

@BlankParticle BlankParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents users from creating convos without having a identity assigned to them
We can actually create convos with internal org members if we dont have a email identity.

So what you might consider is check when user adds a email/contact participant and block that if they dont have a email identity, not block the participants popup

@SySagar
Copy link
Contributor Author

SySagar commented Aug 23, 2024

@BlankParticle please check,

@BlankParticle BlankParticle merged commit 720d960 into un:main Aug 29, 2024
3 checks passed
BlankParticle added a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENG-104] new convo without email identity empty field
2 participants