Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logs for duplicate invite #758

Merged
merged 4 commits into from
Aug 31, 2024
Merged

fix: logs for duplicate invite #758

merged 4 commits into from
Aug 31, 2024

Conversation

SySagar
Copy link
Contributor

@SySagar SySagar commented Aug 30, 2024

What does this PR do?

Fixes #750

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

@McPizza0
Copy link
Member

@SySagar Great work
the checks are failing
can you check them locally with pnpm run check

@SySagar SySagar force-pushed the invite-logs branch 2 times, most recently from c663a54 to a3b21ba Compare August 30, 2024 17:53
@SySagar
Copy link
Contributor Author

SySagar commented Aug 30, 2024

@McPizza0 please check.

Copy link
Member

@BlankParticle BlankParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't handle error if you are going to rethrow them without using the error for anything else

Copy link
Member

Merge activity

  • Aug 31, 3:32 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@BlankParticle BlankParticle merged commit dc310f3 into un:main Aug 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug): duplicate email in invite shows error logs.
3 participants