Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cache headers to storage proxies #762

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Aug 31, 2024

What does this PR do?

Add Cache headers to storage to cache avatar and attachments on user's browser

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BlankParticle and the rest of your teammates on Graphite Graphite

@BlankParticle BlankParticle marked this pull request as ready for review August 31, 2024 16:01
@BlankParticle BlankParticle force-pushed the blank/chore/cache-storage-proxies branch from e2268f4 to 60f62b9 Compare August 31, 2024 16:03
Copy link
Member

@McPizza0 McPizza0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why
avatars are already cached by default in browsers
attachments are not needed to be cached since theyre super rarely opened

@BlankParticle
Copy link
Member Author

Avatars are cached until the page is closed, we need to cache them between reloads
about attachments, inline images are also attachments, so we need to cache them so that we dont call our storage everytime we load them

@BlankParticle BlankParticle merged commit c32a19f into main Sep 1, 2024
5 checks passed
Copy link
Member Author

Merge activity

@BlankParticle BlankParticle deleted the blank/chore/cache-storage-proxies branch September 1, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants