Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add juno filter #245

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions site/css/juno.min.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions site/filters.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
},
{
"name": "Juno",
"is_done": false,
"is_done": true,
"usage": "juno"
},
{
Expand Down Expand Up @@ -203,4 +203,4 @@
],

"images": ["atx", "bike", "cacti", "lakegeneva", "tahoe"]
}
}
41 changes: 41 additions & 0 deletions source/css/juno.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/*
*
* Juno
*
*/

.juno {
position: relative;
-webkit-filter: contrast(1.25) brightness(0.989) saturate(1.1) grayscale(0.19);
filter: contrast(1.25) brightness(0.989) saturate(1.1) grayscale(0.19); }

.juno img {
width: 100%;
z-index: 1; }

.juno:before {
content: '';
display: block;
height: 100%;
width: 100%;
top: 0;
left: 0;
position: absolute;
pointer-events: none;
z-index: 2; }

.juno:after {
content: '';
display: block;
height: 100%;
width: 100%;
top: 0;
left: 0;
position: absolute;
pointer-events: none;
z-index: 3; }

.juno::after {
background: -webkit-radial-gradient(circle, rgba(150, 160, 150, 0.4) 100%, #c06ec9);
background: radial-gradient(circle, rgba(150, 160, 150, 0.4) 100%, #c06ec9);
mix-blend-mode: overlay; }
1 change: 1 addition & 0 deletions source/css/juno.min.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion source/scss/cssgram.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@
@import 'slumber';
@import 'brannan';
@import 'valencia';
@import 'kelvin';
@import 'kelvin';
@import 'juno';
41 changes: 41 additions & 0 deletions source/scss/juno.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/*
*
* Juno
*
*/
@import 'shared';

// mixin to extend juno filter
// @mixin juno
// @param $filters... {filter} - Zero to many css filters to be added
// @example
// img {
// @include juno;
// }
// or
// img {
// @include juno(blur(2px));
// }
// or
// img {
// @include juno(blur(2px)) {
// /*...*/
// };
// }
@mixin juno($filters...) {
@include filter-base;
filter: contrast(1.25) brightness(.989) saturate(1.1) grayscale(.19) $filters;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just remove brightness, since .989 isn't going to be making much of a difference here


&::after {
background: radial-gradient(circle, rgba(150, 160, 150, .4) 100%, rgb(192, 110, 201));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks awesome!! The only change I would make is changing this first value in the gradient from rgba(150, 160, 150, .4) to rgba(150, 160, 150, .8) -- try that and let me know what you think.

mix-blend-mode: overlay;
}

@content;
}

// juno Instagram filter
%juno,
.juno {
@include juno;
}