-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: Invert deep crawling scorer logic for correct priority #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary
Fixes #1080
List of files changed and why
Inverted the scoring function of the
PathDepthScorer
as it was giving a path that has a higher distance to the optimal depth a lower score and a path that is close to the optimal depth a higher score.Also updated the precomputed values that are only used by the
PathDepthScorer
.Done the same thing with KeywordRelevanceScorer, ContentTypeScorer, FreshnessScorer and DomainAuthorityScorer.
The file bff_strategy.py states:
Lower scores are treated as higher priority.
However, the current implementation treats higher score values as better, which contradicts this statement.How Has This Been Tested?
I testet the code before and after this change and it works as expected after the change.
Checklist: