Add a testament parameter #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvahowe Do we know who else (other than my TN TSV7 -> TSV9 script which has to take an UHB/UGNT Quote and determine the ULT quote) uses this repo? |
mvahowe
requested changes
Jun 15, 2022
There was a problem hiding this comment.
Hi!
First, sincere apologies for losing track of this for so long.
The unit tests hang on the first test of alignment. I think that the initial problem is the signature of getDocuments in the test.
It seems like we're finally ready to use this code, so any other patches would be most welcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it doesn't need to load both UHB and UGNT by default
This is the first of a number of changes that I needed to make in order to backport TSV7 TN to TSV9, i.e., to get GLQuote from OrigQuotes. So this is just a very simple PR to test the process. I don't know who else uses this code/repo?
This change is