Bugfix/1908: handle multidimensional polars Array type #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2025 11:34
Signed-off-by: Henri Suominen <[email protected]>
Signed-off-by: Henri Suominen <[email protected]>
hsuominen
force-pushed
the
bugfix/1908
branch
from
4fb8838 to
b9b100d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1909 +/- ##
==========================================
- Coverage 94.28% 93.38% -0.90%
==========================================
Files 91 121 +30
Lines 7013 9369 +2356
==========================================
+ Hits 6612 8749 +2137
- Misses 401 620 +219 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Henri Suominen <[email protected]>
cosmicBboy
reviewed
Feb 20, 2025
There was a problem hiding this comment.
thanks @hsuominen ! would you mind adding a test? See inline comment
Signed-off-by: Henri Suominen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1908