LRE failure for chunking #2608
Open
LRE failure for chunking #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 92 92
Lines 4193 4198 +5
=======================================
+ Hits 4140 4145 +5
Misses 53 53 ☔ View full report in Codecov by Sentry. |
|
Converting this back to draft because @natestemen suggested to write a better test. |
purva-thakre
commented
Jan 14, 2025
mitiq/lre/tests/test_lre.py
Outdated
| assert abs(lre_exp_val - ideal_val) <= abs(noisy_val - ideal_val) | ||
| # verify we get an expectation value | ||
| assert(lre_exp_val_chunking) > 0 | ||
|
|
There was a problem hiding this comment.
@natestemen I cannot think of a better test here. Which is why I decided to check the function does provided a non-zero expectation value.
test_layerwise_folding already has a test comparing the number of noise-scaled layers for a chunked and a non-chunked circuit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed in #2601
https://github.com/unitaryfund/mitiq/actions/runs/12433520415/job/34715234002?pr=2601#step:6:4591
Originally, the test was written to confirm chunking a circuit performs worse in certain scenarios. However, this performance varies non-deterministically. Due to this reason, now the test is verifying there is a difference between two expectation values.
License
Before opening the PR, please ensure you have completed the following where appropriate.