-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: debugging missing stage in pagination #261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngachung
approved these changes
Nov 8, 2023
ngachung
added a commit
that referenced
this pull request
Jan 4, 2024
* fix: debugging missing stage in pagination (#261) * fix: debugging missing stage in pagination * fix: printing request url * fix: testing pagination issue * fix: did not work. reverting * fix: debugging why stage is not forwarded * fix: store stage in ENV for pagination link * fix: missing / in front of stage * chore: add comments * fix: need to create index first * fix: udpate test to check links have stage * chore: refactor some code * fix: using ENV to add prefix * fix: updating base url env * fix: root url does not match * fix: PR creationg to update version failed (#270) * fix: debugging missing stage in pagination * fix: version PR not creating (#265) * fix: mock commit * fix: more mock * fix: PR creation failed (#266) * fix: mock commit * fix: more mock * fix: adding print messages * fix: mock update * fix: still PR issue (#267) * fix: mock commit * fix: more mock * fix: adding print messages * fix: mock update * fix: mock update * fix: more mock update * fix: still PR issue. did see some errors (#268) * fix: mock commit * fix: more mock * fix: adding print messages * fix: mock update * fix: mock update * fix: more mock update * fix: still fixing PR issue * fix: mock commit * chore: update version + change log (#271) Co-authored-by: wphyojpl <[email protected]> * feat: Collection validation in catalog (#264) * fix: debugging missing stage in pagination * fix: check collection details before catalog * chore: update version + change log (#273) Co-authored-by: ngachung <[email protected]> * fix: Metadata stac generate cmr file postfix (#263) * fix: debugging missing stage in pagination * fix: add missing postfix * chore: update version + change log (#275) Co-authored-by: ngachung <[email protected]> --------- Co-authored-by: wphyojpl <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: wphyojpl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260