Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Granuile CNM Ingester TF #365

Merged
merged 6 commits into from
Apr 24, 2024
Merged

feat: Add Granuile CNM Ingester TF #365

merged 6 commits into from
Apr 24, 2024

Conversation

wphyojpl
Copy link
Collaborator

@wphyojpl wphyojpl commented Apr 16, 2024 •
edited
Loading

Closes #357

  • Lambda is a mockup designed to throw an error straight away to test retry logic
  • S3 bucket is attempted, but commented out due to IAM policies
  • Tested that Lambda is invoked 3 times and message is sent to DLQ
  • Not sure if we should add logic to notify admins in such cases. But it should be a different ticket since there are many thresholds to consider and different ways to notify.

@wphyojpl wphyojpl requested a review from ngachung April 16, 2024 21:20
@ngachung ngachung merged commit ac4e886 into develop Apr 24, 2024
1 check passed
@wphyojpl wphyojpl deleted the pipeline branch April 24, 2024 16:13
@ngachung ngachung mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngachung ngachung ngachung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create trigger pipeline for acting on successful_features_*.json S3 uploads
2 participants
@wphyojpl @ngachung