Some more verbose/improved error logging for the bootstrap process. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galenatjpl
reviewed
Jan 14, 2025
| processes.BootstrapEnv(&appConfig) | ||
| err := processes.BootstrapEnv(&appConfig) | ||
| if err != nil { | ||
| log.Errorf("Errors were encountered during bootstrap process. Please check the errorlog for more details.") |
There was a problem hiding this comment.
Can the err object be printed out, to see details of the error?
galenatjpl
reviewed
Jan 14, 2025
| } | ||
|
|
||
| log.Infof("Bootstrap Process Completed Succesfully") | ||
| return nil |
There was a problem hiding this comment.
Is this return statement necessary? There wasn't a return here previously, and I just wasn't sure if this was a best practice, or it may change some behavior?
There was a problem hiding this comment.
oh never mind, I see why you are returning now
galenatjpl
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.