Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated networking ssm param to be consistent with cs-infra #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

galenatjpl
Copy link
Collaborator

Purpose

@drewm-swe
Copy link
Contributor

Are service areas migrating their terraform to this repo?

@galenatjpl
Copy link
Collaborator Author

@drewm-jpl I'm not sure. I did this search:
https://github.com/search?q=org%3Aunity-sds+cs%2Faccount%2Fnetwork&type=code
because we are changing
/unity/cs/account/network/subnet_list
/unity/cs/account/network/vpc_id
to
/unity/account/network/subnet_list
/unity/account/network/vpc_id

I'm just covering all bases by making this PR. I will be creating some other PRs on the unity-sps repo soon, as well

@drewm-swe
Copy link
Contributor

drewm-swe commented Aug 28, 2024

Ok, thanks Galen. I'll check with @mike-gangl. I'm just unsure why old SPS terraform is currently duplicated in this repo.

@galenatjpl
Copy link
Collaborator Author

@drewm-jpl @mike-gangl , let's just go ahead and approve and merge in. Regardless of why this is here, I think we should just make it consistent.

@drewm-swe
Copy link
Contributor

Ok, we can do that if you would like. The SPS terraform that is duplicated in this repo is already extremely out of date with what is in unity-sps. Can you add me as a reviewer then I can approve and merge? Mike may have to add me as a collaborator on this repo for me to be able to approve and merge.

@galenatjpl galenatjpl requested a review from drewm-swe August 28, 2024 22:45
@drewm-swe
Copy link
Contributor

I have permissions to approve but not to merge.

@galenatjpl
Copy link
Collaborator Author

thanks @drewm-jpl . I added a few reviewers that have write permissions, which should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants