Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockdown ECS ALB to only allow Shared Services connections #11

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

jpl-btlunsfo
Copy link
Contributor

Purpose:

Restricting the previously completely open unity proxy ALB to only allow connections from the shared services account and proxy.

Changes

  • ADD vpc peering connection lookups
  • CHANGE original ALB SG ingress rules based on the returned information
  • CHANGE ALB subnet and internal flags

Issues

Testing

@jpl-btlunsfo jpl-btlunsfo self-assigned this Jan 19, 2025
@jpl-btlunsfo jpl-btlunsfo force-pushed the 431-lockdown-ecs-alb-shared-services branch from 294a27e to 9a935b6 Compare January 19, 2025 07:42
@jpl-btlunsfo
Copy link
Contributor Author

Successfully deployed with security-group based restrictions! Should be available at: https://www.dev.mdps.mcp.nasa.gov:4443/btl-dc2/dev/management/ui/landing

Just to note though, since this endpoint is now locked down, it will no longer be available to check during run.sh, which means we'll probably need to update this line to use the shared services endpoint:
https://github.com/unity-sds/unity-cs-infra/blob/main/nightly_tests/run.sh#L353

Copy link
Collaborator

@galenatjpl galenatjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@jpl-btlunsfo jpl-btlunsfo merged commit ff8fc11 into main Jan 22, 2025
1 check passed
@jpl-btlunsfo jpl-btlunsfo deleted the 431-lockdown-ecs-alb-shared-services branch January 22, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants