-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring forward SPS marketplace adjustments #245
Conversation
apparently have been calling the wrong lambda the whole time
- adjusting eks module source branch - adding project/venue variables as args to eks - adding management-console required variables - fixing sps initiators module sources - adding mc-required variables to airflow terraform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jpl-btlunsfo : I was able to deploy from this branch and execute the DAGs successfully. Only question: what are the new parameters needed by the Management Console? In particular, can we set "deployment_name" to be the same as "project", so we don't have to define the same value twice for 2 different variables?
The management console, when installing terraform modules/applications, does a really odd force-injection of variables here. I think the terraform call includes some 'strict' setting, as the absence of any of the variables included there in the actual terraform config throws a fatal error (in the management console output at least).
I guess we could set its default to something simple (like a |
@jpl-btlunsfo : ok, can you set the default value of "deployment_name" to be ""? Then we can merge these changes. |
tag updated, just need an approval to merge (will hold merging until I run another test-deploy). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, approved.
Purpose
Proposed Changes
Issues
Testing
unity-venue-dev
underbtl-df1
/dev
(standard password)