Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding empty "" for deployment name for EKS and Karpenter #248

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Adding empty "" for deployment name for EKS and Karpenter #248

merged 1 commit into from
Dec 10, 2024

Conversation

LucaCinquini
Copy link
Collaborator

Purpose

  • Adding a sensible default for the "deployment_name" variable for EKS and Karpenter

Proposed Changes

  • [CHANGE] The "deployment_name" variable defaults to ""

Issues

  • No associated issue, this is a quick fix

Testing

  • Successfully deployed EKS and Karpenter without having to specify the value of "deployment_name"

@jpl-btlunsfo jpl-btlunsfo merged commit c37b735 into develop Dec 10, 2024
2 checks passed
@jpl-btlunsfo jpl-btlunsfo deleted the sps-deployment-fix branch December 10, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpl-btlunsfo jpl-btlunsfo jpl-btlunsfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucaCinquini @jpl-btlunsfo