Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Feature] Replace selection of CPU, memory with selection of specific EC2 type #258

Merged
merged 3 commits into from
Jan 13, 2025
Merged

[New Feature] Replace selection of CPU, memory with selection of specific EC2 type #258

merged 3 commits into from
Jan 13, 2025

Conversation

LucaCinquini
Copy link
Collaborator

Purpose

  • This PR will allow users to select a specific EC2 type when executing a CWL workflow, while removing the ability to generically select memory and CPU. The latter can lead to workflow failures if the user is not careful about their selection.

Proposed Changes

  • [ADD] DAG parameter to select an EC2 type, replacing the parameters to select CPU and memory
  • [CHANGE] All integration tests to request an instance type and not a certain amount of memory and CPU

Issues

Testing

  • Integration tests succeeded on personal "luca-1" SPS instance

@LucaCinquini LucaCinquini merged commit bdf1bd0 into develop Jan 13, 2025
6 checks passed
@LucaCinquini LucaCinquini deleted the 252-select-ec2-type branch January 13, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpl-btlunsfo jpl-btlunsfo jpl-btlunsfo approved these changes

Assignees

@nikki-t nikki-t

@jpl-btlunsfo jpl-btlunsfo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucaCinquini @jpl-btlunsfo @nikki-t