Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRL IDPS initiators #329

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

SRL IDPS initiators #329

wants to merge 15 commits into from

Conversation

pymonger
Copy link
Contributor

Purpose

  • Clear, easy-to-understand sentences outlining the purpose of the PR

Proposed Changes

  • [ADD] ...
  • [CHANGE] ...
  • [FIX] ...

Issues

  • Links to relevant issues
  • Example: issue-XYZ

Testing

  • Provide some proof you've tested your changes
  • Example: test results available at ...
  • Example: tested on operating system ...

@pymonger pymonger self-assigned this Mar 11, 2025
This was linked to issues Mar 11, 2025
Initiators: Breakout vic2png into a separate Airflow DAG unity-sds/unity-cs#433
Closed
Initiators: Schedule and Do Airflow / vic2png / round-trip demo unity-sds/unity-cs#434
Closed
@pymonger pymonger mentioned this pull request Mar 11, 2025
Closed
@pymonger pymonger marked this pull request as ready for review March 11, 2025 22:03
LucaCinquini
LucaCinquini approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@LucaCinquini LucaCinquini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, please go ahead and merge into "develop". We might want to add:
o instructions on how to deploy the additional AWS components needed for the end-to-end demo
o tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaCinquini LucaCinquini LucaCinquini approved these changes

@nikki-t nikki-t Awaiting requested review from nikki-t

Assignees

@pymonger pymonger

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pymonger @LucaCinquini