Skip to content

394 increase test coverage #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Conversation

nikki-t
Copy link
Collaborator

@nikki-t nikki-t commented Apr 16, 2025

Purpose

Add integration tests for use cases that were recently converted to the modular CWL DAG:

  • SBG Preprocess
  • SBG Isofit

Proposed Changes

  • [ADD] SBG_PREPROCESS and SBG_ISOFIT test cases to both Airflow API and OGC API integration tests

Issues

Testing

Ran each test in unity-venue-dev on unity-nikki-1 deployment from laptop (unable to run tests in GitHub as waiting on Cognito token work).

Tests completed successfully, current execution times:

  • SBG PREPROCESS: 00:15:52
  • SBG ISOFIT: 00:47:02

@nikki-t nikki-t requested a review from LucaCinquini April 16, 2025 20:32
@nikki-t nikki-t self-assigned this Apr 16, 2025
@nikki-t
Copy link
Collaborator Author

nikki-t commented May 23, 2025

The tests appear to be working in the dev environment after I changed the EC2 instance type for the SBG E2E test: https://github.com/unity-sds/unity-sps/actions/runs/15211329454/job/42785955045

It seemed like it kept getting terminated and I am wondering if that had something to do with the spot instance architecture.

The test environment failed at stage in:

[2025-05-23T13:55:22.834+0000] {pod_manager.py:471} INFO - [base] 2025-05-23 13:55:22,756 [INFO] [botocore.credentials::1075] Found credentials from IAM Role: unity-test-sps-eks-eks-node-role
[2025-05-23T13:55:23.001+0000] {pod_manager.py:471} INFO - [base] 2025-05-23 13:55:22,833 [INFO] [botocore.credentials::1075] Found credentials from IAM Role: unity-test-sps-eks-eks-node-role
[2025-05-23T13:55:23.002+0000] {pod_manager.py:471} INFO - [base] 2025-05-23 13:55:22,999 [ERROR] [mdps_ds_lib.stage_in_out.download_granules_abstract::63] error downloading granule: urn:nasa:unity:unity:dev:SBG-L1B_PRE___1:SISTER_EMIT_L1B_RDN_20240103T131936_001
...
[2025-05-23T13:55:26.010+0000] {pod_manager.py:471} INFO - [base] botocore.exceptions.ClientError: An error occurred (403) when calling the HeadObject operation: Forbidden

It seems like a permissions issue?

@nikki-t nikki-t marked this pull request as ready for review May 23, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant