-
Notifications
You must be signed in to change notification settings - Fork 4
Fixing OGC integration tests for Cognito #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a3b4b3
to
0dbe70c
Compare
…r status. adding in a hopeful workaround for OGC
…new client while we're here
e42692b
to
31aadb8
Compare
Moving out of draft, tested a few times in github integration tests. @LucaCinquini I PR'd a fix into the sds client, and removed that hacky workaround. Everything looks good/ready to merge. Tests in unity-venue-test arent working right now, but I believe that's a credential issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! One question, I can't seem to figure out how the access token is passed to the OGC API tests? I see it for the Airflow API tests as the fetch_token
fixture gets passed into the test function.
The OGC client is using the shared unity SDS client, which does (basically) everything |
…tion-tests-cognito-luca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SBG_ISOFIT with cwl_modular_dag fails, but it is a question of resources. This set has working examples with Airflow and OGC APIs, and for CWL classic and CWL modular DAG, proving the infrastructure is ok.
Purpose
Proposed Changes
Issues
Testing