Skip to content

Fixing OGC integration tests for Cognito #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 17, 2025

Conversation

jpl-btlunsfo
Copy link
Collaborator

@jpl-btlunsfo jpl-btlunsfo commented May 6, 2025

Purpose

  • Update OGC integration tests to properly use cognito authentication

Proposed Changes

  • CHANGE environment variable naming to match what the sds client will look for

Issues

Testing

  • Testing with this PR

@jpl-btlunsfo jpl-btlunsfo requested a review from LucaCinquini May 6, 2025 19:29
@jpl-btlunsfo jpl-btlunsfo self-assigned this May 6, 2025
@jpl-btlunsfo jpl-btlunsfo marked this pull request as draft May 7, 2025 20:38
@jpl-btlunsfo jpl-btlunsfo force-pushed the 384-fix-integration-tests-cognito branch from 1a3b4b3 to 0dbe70c Compare June 3, 2025 18:21
@jpl-btlunsfo jpl-btlunsfo force-pushed the 384-fix-integration-tests-cognito branch from e42692b to 31aadb8 Compare June 11, 2025 18:26
@jpl-btlunsfo jpl-btlunsfo marked this pull request as ready for review June 11, 2025 18:26
@jpl-btlunsfo jpl-btlunsfo requested a review from nikki-t June 11, 2025 18:26
@jpl-btlunsfo
Copy link
Collaborator Author

Moving out of draft, tested a few times in github integration tests.

@LucaCinquini I PR'd a fix into the sds client, and removed that hacky workaround. Everything looks good/ready to merge. Tests in unity-venue-test arent working right now, but I believe that's a credential issue.

Copy link
Collaborator

@nikki-t nikki-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! One question, I can't seem to figure out how the access token is passed to the OGC API tests? I see it for the Airflow API tests as the fetch_token fixture gets passed into the test function.

@jpl-btlunsfo
Copy link
Collaborator Author

This looks great! One question, I can't seem to figure out how the access token is passed to the OGC API tests? I see it for the Airflow API tests as the fetch_token fixture gets passed into the test function.

The OGC client is using the shared unity SDS client, which does (basically) everything fetch_token does, internally.

Copy link
Collaborator

@LucaCinquini LucaCinquini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SBG_ISOFIT with cwl_modular_dag fails, but it is a question of resources. This set has working examples with Airflow and OGC APIs, and for CWL classic and CWL modular DAG, proving the infrastructure is ok.

@LucaCinquini LucaCinquini merged commit 894a538 into develop Jun 17, 2025
6 checks passed
@LucaCinquini LucaCinquini deleted the 384-fix-integration-tests-cognito branch June 17, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants