Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous testing best practices from SLIM #94

Merged
merged 8 commits into from
Jul 13, 2024

Conversation

yunks128
Copy link
Contributor

Purpose

  • This pull request aims to improve the CI/CD pipeline by adding automated integration and smoke test result checks and refining the unit test execution process. It also includes the addition of static code analysis and other test configurations.

Proposed Changes

  • [ADD] .github/dependabot.yml to schedule dependency updates daily.
  • [ADD] Check Integration Tests Results step in .github/workflows/integration_tests.yml to fail the job if tests fail.
  • [CHANGE] Updated Check Smoke Tests Results step in .github/workflows/smoke_tests.yml to provide detailed feedback on which specific smoke tests failed.
  • [CHANGE] Modified .github/workflows/unit_tests.yml to add manual workflow dispatch support.
  • [ADD] unity-test/TESTING.md to provide comprehensive documentation on the testing architecture and processes for the project.

Issues

  • This pull request addresses the need for improved CI/CD pipeline automation and reliability.
  • It ensures automated checks for integration and smoke tests, failing the job if any test fails, providing detailed feedback on failures.
  • It includes enhancements to support manual workflow dispatch for unit tests.
  • Introduces comprehensive documentation for testing architecture and processes, facilitating better understanding and maintenance.

Testing

  • Tested on Ubuntu-latest environment via GitHub Actions.
  • Manual checks to ensure the added steps and conditions trigger correctly.

@yunks128 yunks128 changed the title Enhance CI/CD Pipeline Automation and Test Plan Documentation with Updated Testing Framework Continuous testing best practices from SLIM May 23, 2024
@yunks128 yunks128 marked this pull request as ready for review May 23, 2024 23:07
@drewm-swe drewm-swe self-requested a review June 12, 2024 20:55
Copy link
Contributor

@drewm-swe drewm-swe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunks128 Looks good, thanks for your contribution.

@drewm-swe
Copy link
Contributor

@yunks128 can you fix the static analysis failure?

@drewm-swe
Copy link
Contributor

It appears there is still a trailing whitespace issue with the static analysis.

@yunks128
Copy link
Contributor Author

@drewm-jpl, the trailing whitespace issue is fixed, but another error remains. I don't see "--no-fail-on-changed" anywhere, but the error is there. Do you have any idea? Thanks.
"check-added-large-files: error: unrecognized arguments: --no-fail-on-changed"

yunks128 added 2 commits July 11, 2024 22:17
removed --no-fail-on-changed argument that's causing a problem
@yunks128
Copy link
Contributor Author

@drewm-jpl
Fixed this problem. no errors now! Thanks!

@drewm-jpl, the trailing whitespace issue is fixed, but another error remains. I don't see "--no-fail-on-changed" anywhere, but the error is there. Do you have any idea? Thanks. "check-added-large-files: error: unrecognized arguments: --no-fail-on-changed"

@drewm-swe drewm-swe merged commit b55a7c1 into unity-sds:develop Jul 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants