Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Dockstore & Jupyter working inside Navbar #19

Open
Tracked by #6
rtapella opened this issue Jan 11, 2024 · 18 comments
Open
Tracked by #6

Get Dockstore & Jupyter working inside Navbar #19

rtapella opened this issue Jan 11, 2024 · 18 comments
Assignees

Comments

@rtapella
Copy link
Contributor

No description provided.

@rtapella rtapella converted this from a draft issue Jan 11, 2024
@rtapella
Copy link
Contributor Author

CORS updates so we can display Dockstore and Jupyter with the common navbar on top

@rtapella
Copy link
Contributor Author

dockstore depends on : unity-sds/unity-ads-deployment#135

@rtapella
Copy link
Contributor Author

rtapella commented Jan 30, 2024

relates to "figure out CORS stuff" #6

@rtapella
Copy link
Contributor Author

@mcduffie what info do you need from us to configure Dockstore / Jupyter to be happy with CORS requests from the navbar UI to Dockstore and Jupyter?

Can we read the locations of each app from SSM?

@rtapella
Copy link
Contributor Author

rtapella commented Apr 2, 2024

Putting this into 24.2 along with the Jupyter -> Marketplace work

@rtapella
Copy link
Contributor Author

rtapella commented Apr 8, 2024

For Jupyterhub, this depends on unity-sds/unity-project-management#90

@GodwinShen
Copy link

@rtapella is there anything that you and Anil can do ahead of James' MC deployment? Seems to me that it could still be integrated into the Navbar without the MC-method for deployment, @mcduffie and @edwinsarkissian already have Dockstore and Jupyterhub deployments working in some of the venues, can we just hook up to those venues in the mean-time to demonstrate this is working in the Navbar?

@rtapella
Copy link
Contributor Author

We are expecting that when all the apps are deployed via marketplace, they will have the new domain-name address. This “should” resolve the CORS issue. Until then we cannot verify that it will “just work” out of the box.

@rtapella
Copy link
Contributor Author

(We have tried pointing at the dev URLs and we get CORS issues blocking the frame)

@rtapella
Copy link
Contributor Author

rtapella commented Jun 4, 2024

Jupyter is at: https://www.dev.mdps.mcp.nasa.gov:4443/unity/dev/jupyter

It should help with the CORS issues

@rtapella
Copy link
Contributor Author

rtapella commented Jun 5, 2024

@mcduffie is there a known URL for Dockstore as well?

Are both Dockstore and Jupyter sending status & landing page to the health system?

@rtapella
Copy link
Contributor Author

rtapella commented Jun 5, 2024

@mcduffie what authentication is Dockstore using at this point? is it also Cognito or still Github/other?

@mcduffie
Copy link

Still Github.com

@rtapella
Copy link
Contributor Author

@anilnatha so what happens if we have multiple auth systems supporting the iframe'd apps? Or do we need some sort of config for each app to understand the authorization?

@rtapella
Copy link
Contributor Author

rtapella commented Aug 5, 2024

@mcduffie we will need the jupyter & dockstore health-endpoint URLs to have the MCP URL
then it should show up in the navbar and work properly

@mcduffie
Copy link

mcduffie commented Aug 5, 2024

@rtapella I need to have a proxying that actually works before I can give you an appropriate URL. Once the proxying is fixed I can be sure the URL wont change.

@rtapella
Copy link
Contributor Author

rtapella commented Aug 27, 2024

@rtapella
Copy link
Contributor Author

Jupyter needs to be hooked up to the health_endpoint

Same with Dockstore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants