Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a way to incorporate other apps (CORS issues etc.) #6

Open
1 of 3 tasks
rtapella opened this issue Sep 18, 2023 · 13 comments
Open
1 of 3 tasks

Figure out a way to incorporate other apps (CORS issues etc.) #6

rtapella opened this issue Sep 18, 2023 · 13 comments
Assignees
Labels
Epic Container for related work U-UIUX

Comments

@rtapella
Copy link
Contributor

rtapella commented Sep 18, 2023

Help each respective service team set up their apps to be included "under" the navbar (CORS etc.)

@rtapella rtapella converted this from a draft issue Sep 18, 2023
@rtapella rtapella moved this to Todo in Unity Project Board Sep 18, 2023
@rtapella
Copy link
Contributor Author

@rtapella
Copy link
Contributor Author

also get Airflow working inside Navbar

@rtapella
Copy link
Contributor Author

dependencies are 24.1.5... so this cannot be done before that

@rtapella
Copy link
Contributor Author

Start with Airflow (#22 )

@rtapella rtapella moved this from Todo to In Progress in Unity Project Board Mar 25, 2024
@anilnatha
Copy link
Collaborator

anilnatha commented Apr 29, 2024

@galenatjpl The reason we have had CORS issues in the past is because the services we were loading into the UI were being served from URLs that weren't part of the same domain, i.e. not routed through the venue's CloudFront instance.

Assuming that the service areas will be using a venue's cloudfront instance to provide user's access to their respective UIs (dockstore, stac browser, airflow, etc.), won't CORS issue be a moot point?

@galenatjpl
Copy link

galenatjpl commented Apr 29, 2024

@anilnatha , Both @ramesh-maddegoda and @mike-gangl were working on a httpd server that has a ALB and cert. I think @mike-gangl was thinking that airflow is a "www" thing, and not an "api" thing, and therefore would go through httpd.

In other words,
www.* points to the httpd load balancers
api.* points to API Gateways

So the other apps (and the Navbar UI) should have URLs starting with https://www.dev.mdps.mcp.nasa.gov:4443/ ...

So I think the answer hopefully is that you don't have this CORS issue anymore (once this all gets setup properly), but we would have to test.

@mike-gangl
Copy link

There may still be some CORS issues to resolve, e.g. submitting a job to the API (WPS) from the dashboard, but i think those belonging to the same domain will help alleviate these issues.

As for hosting another application, its essentially an iframe pointing at www... content, so that should be pretty standard.

@rtapella rtapella moved this from In Progress to Blocked in Unity Project Board May 6, 2024
@rtapella rtapella removed the blocked label May 6, 2024
@rtapella
Copy link
Contributor Author

rtapella commented May 6, 2024

needs u-cs work on httpd resolved

@rtapella
Copy link
Contributor Author

rtapella commented May 6, 2024

May need to handle the APIs because they'll have a different domain (api.blah vs. www.blah) when loading the Jobs Dashboard (for example)

@rtapella
Copy link
Contributor Author

rtapella commented Jun 4, 2024

@anilnatha I think we can test Jupyter in the navbar now... it should have a URL that can avoid the CORS stuff

@rtapella
Copy link
Contributor Author

rtapella commented Jun 5, 2024

also need to handle passing of Cognito tokens into the iframe

@rtapella
Copy link
Contributor Author

rtapella commented Jul 9, 2024

Cognito into iframe = cookies. Working on it

@rtapella
Copy link
Contributor Author

rtapella commented Aug 5, 2024

Each health-endpoint URL should have the MCP URL
then it should show up in the navbar and work properly

@rtapella rtapella moved this from Blocked to In Progress in Unity Project Board Aug 5, 2024
@rtapella rtapella moved this from In Progress to Todo in Unity Project Board Aug 5, 2024
@anilnatha anilnatha added the Epic Container for related work label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Container for related work U-UIUX
Projects
Status: Todo
Development

No branches or pull requests

4 participants