Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Airflow working inside Navbar #22

Open
Tracked by #6
rtapella opened this issue Feb 15, 2024 · 16 comments
Open
Tracked by #6

Get Airflow working inside Navbar #22

rtapella opened this issue Feb 15, 2024 · 16 comments
Assignees
Labels
Epic Container for related work U-SPS U-UIUX

Comments

@rtapella
Copy link
Contributor

No description provided.

@rtapella
Copy link
Contributor Author

@LucaCinquini what info do you need from us to configure Airflow to be happy with CORS requests from the navbar UI to Airflow?

Can we read the location from SSM?

@rtapella rtapella moved this from Todo to In Progress in Unity Project Board Mar 25, 2024
@LucaCinquini
Copy link

Yes, the location is in SSM and @drewm-jpl can tell you which is the parameter to use. But I think the UI/UX team should try to include it in the NavBar and see what problems arise. As I mentioned earlier, I am not sure it is such a great idea to imprison Airflow within another site...

@LucaCinquini LucaCinquini removed their assignment Mar 25, 2024
@drewm-swe
Copy link

To find the Airflow UI URL in a given venue, you can find it in an SSM parameter under this naming convention /unity/dev/sps/${DEPLOYMENT_NAME}/${DEPLOYMENT_COUNTER}/processing/airflow/ui_url

@rtapella rtapella moved this from In Progress to Todo in Unity Project Board Apr 2, 2024
@anilnatha
Copy link
Collaborator

@drewm-jpl My understanding of the param names is that it should follow something like /unity/{project}/{venue}/... but in that path you've shared, dev is hard coded into the SSM Param.

@drewm-swe
Copy link

@anilnatha Whoops, yes that's correct the venue is parameterized in the SSM parameter name as well.

/unity/{venue}/sps/${DEPLOYMENT_NAME}/${DEPLOYMENT_COUNTER}/processing/airflow/ui_url

Currently, project and venue are combined so the SBG dev SSM parameter would appear like this:
/unity/sbg-dev/sps/${DEPLOYMENT_NAME}/${DEPLOYMENT_COUNTER}/processing/airflow/ui_url

There doesn't appear to be guidance on the gitbook docs on how to handle the project/venue combo but that's what we have currently.

@anilnatha
Copy link
Collaborator

@drewm-jpl Thanks for the clarification and addressing my concern.

@galenatjpl Could you please point us to the documentation on how to handle the SSM param naming convention with regards to project and venue. IIRC, it was something like /unity/{project}/{venue}/... but I want to make sure this is accurate.

@galenatjpl
Copy link

@anilnatha I think we are now settling on /unity/{project}/{venue}/.. (see the "Name Form" section here: https://unity-sds.gitbook.io/docs/developer-docs/common-services/docs/users-guide/deployment/deployment-concepts-and-infrastructure/unity-ssm-parameters/ssm-parameter-naming-requirements-and-conventions).
I think at a minimum we need to stick with the /unity/{project}/{venue}/.. convention, so that proj/venue deployments will know what params explicitly apply to them.

@anilnatha anilnatha moved this from Todo to Blocked in Unity Project Board May 6, 2024
@rtapella
Copy link
Contributor Author

@anilnatha please work with @drewm-jpl to update this (e.g. use the health json landingPage URL?) or otherwise get a URL to try out to test this... (assuming the CORS stuff will work)

@GodwinShen
Copy link

@anilnatha and @rtapella ping for status. Is this still blocked?

@rtapella
Copy link
Contributor Author

Once Airflow is deployed with the new URL structure, we can test this out—that will/should avoid CORS issues. Initially we'll just use the URL from the Health Status info for each app.

@rtapella
Copy link
Contributor Author

rtapella commented Aug 5, 2024

@LucaCinquini @drewm-jpl we will need the Airflow health-endpoint URLs to have the MCP URL
then it should show up in the navbar and work properly

@rtapella rtapella moved this from Blocked to In Progress in Unity Project Board Aug 5, 2024
@rtapella rtapella moved this from In Progress to Todo in Unity Project Board Aug 5, 2024
@anilnatha anilnatha added U-SPS Epic Container for related work labels Jan 22, 2025
@anilnatha
Copy link
Collaborator

@LucaCinquini Please add sub-issues to this Epic as needed to address the tasks needed to get Airflow accessible from the navbar (aka portal)

@LucaCinquini
Copy link

So do you simply need a link to the Airflow URL? Isn't that accessible already through the Health Check endpoint?

@anilnatha
Copy link
Collaborator

We're good on the Airflow URLs being provided in the health API endpoint response, but when Airflow is accessed via the portal, there is an error.

Blocked loading mixed active content “http://www.dev.mdps.mcp.nasa.gov:4443/unity/dev/sps/home”

Image

@LucaCinquini
Copy link

Are you trying to display Airflow in an embedded window? Otherwise, the URL works just fine.

@anilnatha
Copy link
Collaborator

Yup, that's exactly what we're trying to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Container for related work U-SPS U-UIUX
Projects
Status: Todo
Development

No branches or pull requests

6 participants