Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/update react router #44

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

anilnatha
Copy link
Collaborator

Purpose

This PR addresses a change to our routing configuration to improve our URL structure.

Proposed Changes

  • [CHANGE] Replaced HashRouter with BrowserRouter to improve readability of our URLs
  • [CHANGE] Updated Apache configuration to always redirect requests to /index.html now that we are using BrowserRouter; otherwise, refreshing causes a 404 to be triggered by Apache
  • [CHANGE] The homepage of the application now lives at /home and any attempt to go to / simply redirects to /home

Issues

Testing

Tested locally

Copy link
Contributor

@rtapella rtapella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try in dev

@rtapella rtapella merged commit 1ae7aee into develop Dec 17, 2024
1 check passed
@anilnatha anilnatha deleted the features/update-react-router branch December 18, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants