-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: web native reimplementation #829
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration: #787
History:
(req, res)
API with unenv direct fetch allowing Nitro to support h3 in webRequest => Response
adapterstoWebHandler
powered by still unenv and supportingResponse
app.fetch
(feat!: overhaul internal design #783, refactor!: overhaul app event handler #792, refactor!: reimplement app with class #820, feat!: integrate router with app andapp.fetch
#822)This PR completely upgrades h3 to be based around modern web
Request => Response
+URL
+Header
APIs (without intermediate abstraction) alongside multiple performance improvements by avoiding extra promise creation (up to 2x faster than initial v2!).Node.js adapter now implements proxies for
Request
,Response
,URL
, andHeaders
giving full two-way sync between Node.js and Web APIs.In order to simplify things, this PR also adds back
event.node?
to access node context in Node.js compatible environments.ufo dependency is removed as now we use web search params for parsing query as well.
This upgrade improves performance and also makes a true web-native HTTP framework with first-class Node.js support!