-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cors)!: doesn't return access-control-allow-origin
header when origin is disallowed
#870
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
==========================================
+ Coverage 77.83% 79.46% +1.63%
==========================================
Files 47 43 -4
Lines 4286 3292 -994
Branches 611 798 +187
==========================================
- Hits 3336 2616 -720
+ Misses 933 673 -260
+ Partials 17 3 -14 ☔ View full report in Codecov by Sentry. |
Can you please add a regression test? |
It's going to be a conflict, so I'll work on it after #856. |
access-control-allow-origin
header when dynamic
access-control-allow-origin
header when dynamicaccess-control-allow-origin
header when origin is disallowed
IMO, |
resolves #355