Fix ResourceNameToResourceString converter #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
reviewed
Aug 1, 2022
| @@ -18,7 +18,7 @@ namespace CommunityToolkit.WinUI.UI.Converters | |||
| /// </summary> | |||
| public sealed class ResourceNameToResourceStringConverter : IValueConverter | |||
| { | |||
| private readonly ResourceLoader _resourceLoader = new ResourceLoader(); | |||
There was a problem hiding this comment.
Looks like we should be fixing uno instead (there's an issue opened IIRC). If I recall properly, ResourceLoader.GetForViewIndependentUse(); is not available under WinAppSDK.
There was a problem hiding this comment.
It seems it's available now. I checked the base repository implementation, and this is how they fixed it.
There was a problem hiding this comment.
The WinUI branch has this change: https://github.com/CommunityToolkit/WindowsCommunityToolkit/blob/080bdb99e6810eb2157ad635f00e64a64acabb50/CommunityToolkit.WinUI.UI/Converters/ResourceNameToResourceStringConverter.cs#L16. We'll need to look at the default instance for the resource loader then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180
Using the
ResourceNameToResourceStringwith key bound returns empty string.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Using the
ResourceNameToResourceStringwith key bound returns empty string.What is the new behavior?
Key in Resource file is returned when it does exist.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information