Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResourceNameToResourceString converter #181

Open
wants to merge 1 commit into
base: uno
Choose a base branch
from
Open

Fix ResourceNameToResourceString converter #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CommunityToolkit.WinUI.UI/Converters/ResourceNameToResourceStringConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace CommunityToolkit.WinUI.UI.Converters
/// </summary>
public sealed class ResourceNameToResourceStringConverter : IValueConverter
{
private readonly ResourceLoader _resourceLoader = new ResourceLoader();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we should be fixing uno instead (there's an issue opened IIRC). If I recall properly, ResourceLoader.GetForViewIndependentUse(); is not available under WinAppSDK.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it's available now. I checked the base repository implementation, and this is how they fixed it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @jeromelaban

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WinUI branch has this change: https://github.com/CommunityToolkit/WindowsCommunityToolkit/blob/080bdb99e6810eb2157ad635f00e64a64acabb50/CommunityToolkit.WinUI.UI/Converters/ResourceNameToResourceStringConverter.cs#L16. We'll need to look at the default instance for the resource loader then.

private readonly ResourceLoader _resourceLoader = ResourceLoader.GetForViewIndependentUse();

/// <summary>
/// Take the source string as a resource name that will be looked up in the App Resources.
Expand Down