-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OnDevice Markup Extension #60
Comments
Unfortunately this still won't work in Uno due to the fact that when I process a custom MarkupExtension, I expect a MarkupExtensionReturnType to be specified. I would need to discuss this with @davidjohnoliver |
@Massimo37 could we just put a |
@michael-hawker yes I thought about that, it's an option I'd like to try once the PR goes through. It would be versatile if the MarkupExtensionReturnType is optional and allows a dev to return different entities (as is allowed with OnDevice). |
MarkupExtensionReturnType is now optional, so that part is done. Unfortunately we still need this feature to be completed until this markup extension is usable: |
I'm on it :-) |
I'm submitting a...
Once Uno supports Markup Extension with unoplatform/uno#39, it'd be cool if the OnDevice one could support other platforms as well from Uno. 😊 (Android, iOS, WASM)
Current behavior
https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/master/Microsoft.Toolkit.Uwp.UI/Extensions/Markup/OnDevice.cs
unoplatform/uno#39
The text was updated successfully, but these errors were encountered: