Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OnDevice Markup Extension #60

Open
michael-hawker opened this issue Sep 21, 2019 · 6 comments
Open

Add OnDevice Markup Extension #60

michael-hawker opened this issue Sep 21, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@michael-hawker
Copy link
Collaborator

I'm submitting a...

Once Uno supports Markup Extension with unoplatform/uno#39, it'd be cool if the OnDevice one could support other platforms as well from Uno. 😊 (Android, iOS, WASM)

  • Feature request

Current behavior

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/master/Microsoft.Toolkit.Uwp.UI/Extensions/Markup/OnDevice.cs

unoplatform/uno#39

@Massimo37
Copy link

Unfortunately this still won't work in Uno due to the fact that when I process a custom MarkupExtension, I expect a MarkupExtensionReturnType to be specified. I would need to discuss this with @davidjohnoliver

@Massimo37 Massimo37 added the enhancement New feature or request label Sep 23, 2019
@Massimo37 Massimo37 self-assigned this Sep 23, 2019
@michael-hawker
Copy link
Collaborator Author

@Massimo37 could we just put a MarkupExtensionReturnType(typeof(object)) on there?

@Massimo37
Copy link

Massimo37 commented Sep 23, 2019

@michael-hawker yes I thought about that, it's an option I'd like to try once the PR goes through. It would be versatile if the MarkupExtensionReturnType is optional and allows a dev to return different entities (as is allowed with OnDevice).

@Massimo37
Copy link

MarkupExtensionReturnType is now optional, so that part is done. Unfortunately we still need this feature to be completed until this markup extension is usable:

unoplatform/uno#1468

@MartinZikmund
Copy link
Member

I'm on it :-)

@MartinZikmund
Copy link
Member

MartinZikmund commented Oct 27, 2019

unoplatform/uno#1970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants