Added a change to make the MarkupExtensionReturnType optional #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
approved these changes
Oct 8, 2019
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
Outdated
Show resolved
Hide resolved
carldebilly
approved these changes
Oct 8, 2019
|
@davidjohnoliver Release notes are updated |
Massimo37
force-pushed
the
dev/mass/optional-return-type
branch
from
2ebc217
to
f75330c
Compare
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
Outdated
Show resolved
Hide resolved
…stom markup extension. This allows a developer to be able to return different types from one markup extension.
…e target property type + release notes
Massimo37
force-pushed
the
dev/mass/optional-return-type
branch
from
4d622c9
to
db92363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #39
PR Type
What kind of change does this PR introduce?
Feature
What is the current behavior?
Currently, markup extensions require the
MarkupExtensionReturnTypeattribute to be specified.What is the new behavior?
Allows the
MarkupExtensionReturnTypeattribute to be optional and allows a developer to be able to return different types from one markup extension.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Allows the following issue to be worked on:
unoplatform/Uno.WindowsCommunityToolkit#60